-
-
Notifications
You must be signed in to change notification settings - Fork 76
Add support for complex dictionary types #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
219cda7
to
e51d98c
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 86.38% 85.96% -0.42%
==========================================
Files 26 26
Lines 2761 2793 +32
Branches 654 666 +12
==========================================
+ Hits 2385 2401 +16
- Misses 284 292 +8
- Partials 92 100 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Awesome! Wanted to add this since a long time ago and you finally did it, haha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! However, there are some conflicts need to be resolved.
8730a8d
to
84624a2
Compare
Same as #170 but for Dict[X, Y]
Note that per default, the plutus dataclasses of pycardano are not frozen and can hence not be used as key values. Technically, this is allowed in plutus.