Skip to content

Add support for complex dictionary types #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

nielstron
Copy link
Contributor

Same as #170 but for Dict[X, Y]

Note that per default, the plutus dataclasses of pycardano are not frozen and can hence not be used as key values. Technically, this is allowed in plutus.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Merging #180 (31bc90c) into main (ab01bec) will decrease coverage by 0.42%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   86.38%   85.96%   -0.42%     
==========================================
  Files          26       26              
  Lines        2761     2793      +32     
  Branches      654      666      +12     
==========================================
+ Hits         2385     2401      +16     
- Misses        284      292       +8     
- Partials       92      100       +8     
Impacted Files Coverage Δ
pycardano/plutus.py 89.40% <46.66%> (-3.18%) ⬇️
pycardano/serialization.py 86.50% <52.94%> (-2.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cffls
Copy link
Collaborator

cffls commented Mar 15, 2023

Awesome! Wanted to add this since a long time ago and you finally did it, haha.

@nielstron nielstron requested a review from cffls March 15, 2023 12:10
Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! However, there are some conflicts need to be resolved.

@cffls cffls merged commit cf41ba1 into Python-Cardano:main Mar 16, 2023
@cffls cffls added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants